fix(packaging): exclude scoped chore and docs commits from roborev
The exclusion patterns are substring matches, so `chore:` never matched `chore(packaging):`. Because the cadence rule in AGENTS.md mandates the `type(ws):` scope, every chore and docs commit was being reviewed -- job 15 spent a thorough review on a config-only commit. Adds the `chore(` and `docs(` forms. Also names pm/compass.toml as authoritative for the review rules, so the prose copy in AGENTS.md cannot silently drift from the generated .roborev.toml. Raised by roborev job 15.
This commit is contained in:
+3
-1
@@ -2,7 +2,9 @@
|
|||||||
# Reviews are queued to a background daemon -- they never block a commit.
|
# Reviews are queued to a background daemon -- they never block a commit.
|
||||||
|
|
||||||
post_commit_review = 'commit'
|
post_commit_review = 'commit'
|
||||||
excluded_commit_patterns = ['WIP', 'chore:', 'docs:', 'Merge ']
|
# Scoped conventional commits (`chore(packaging):`) do not contain `chore:`,
|
||||||
|
# and this repo's cadence rule mandates the scope -- so both forms are listed.
|
||||||
|
excluded_commit_patterns = ['WIP', 'chore:', 'chore(', 'docs:', 'docs(', 'Merge ']
|
||||||
|
|
||||||
review_guidelines = '''
|
review_guidelines = '''
|
||||||
# --- compass:begin (generated -- edit the sources, not this) ---
|
# --- compass:begin (generated -- edit the sources, not this) ---
|
||||||
|
|||||||
@@ -35,6 +35,12 @@ type(ws): subject (#N)
|
|||||||
|
|
||||||
## Conventions
|
## Conventions
|
||||||
|
|
||||||
|
`pm/compass.toml` is authoritative for these rules. Its `[roborev]
|
||||||
|
project_guidelines` are composed into `.roborev.toml`, so change them there and
|
||||||
|
re-run compass rather than editing `.roborev.toml` by hand. The prose below is the
|
||||||
|
same rules stated for a human reader; if the two ever disagree, `pm/compass.toml`
|
||||||
|
wins.
|
||||||
|
|
||||||
**Dependencies.** Base R plus ggplot2 (>= 4.0), grid/gridExtra, png/jpeg, stringr,
|
**Dependencies.** Base R plus ggplot2 (>= 4.0), grid/gridExtra, png/jpeg, stringr,
|
||||||
stringdist, showtext/sysfonts, jsonlite. No tidyverse: no dplyr, purrr, magrittr,
|
stringdist, showtext/sysfonts, jsonlite. No tidyverse: no dplyr, purrr, magrittr,
|
||||||
tibble, or data.table. Prefer an existing dependency or base R over adding one —
|
tibble, or data.table. Prefer an existing dependency or base R over adding one —
|
||||||
|
|||||||
Reference in New Issue
Block a user