2 Commits

Include renames

Author	SHA1	Message	Date
jared	72b2cc3a26	fix: local corpus paths were unreadable on Windows (backslashes eaten) ... gsub() in regex mode treats backslashes in the REPLACEMENT string as escape sequences and silently drops them. A Windows corpus path is full of them, so C:\Users\RUNNER\AppData\... was substituted into the view SQL as C:UsersRUNNERAppData... and every DuckDB read failed with 'No files found that match the pattern'. Effect: uscogdata could not read a LOCAL corpus on Windows at all -- the bundled fixture included, so the entire test suite failed there, and any cog_mirror() copy was unusable. Remote https URLs were unaffected, having no backslashes, which is part of why it stayed hidden. The bug predates the {long_files} token; it lived in the original {url} substitution since that code was written. Nothing ever ran on Windows until the GitHub mirror's check matrix existed, which found it on its first run: 14 of 15 Windows failures were this, the 15th a downstream consequence of view registration failing. fixed = TRUE treats pattern and replacement as literal text. The regression test reproduces on any platform -- it is string handling, not filesystem behaviour, so it needs no Windows runner.	2026-08-09 09:03:44 -04:00
jared	99e1e86e37	fix: enumerate long partitions from the manifest instead of globbing ... DuckDB cannot expand a glob over generic HTTP -- there is no directory listing, and allow_asterisks_in_http_paths only forwards the literal '**/*' as a filename, which 404s. So every remote corpus read failed. Only local paths worked, which is how the API (a host mount) and the test fixture run, so nothing ever caught it. Measured against the published corpus: the explicit list returns the same 46,148,034 rows the hf:// glob does, with hive_partitioning still recovering year from the paths. Building it from the manifest keeps the reader host-agnostic rather than binding it to one vendor's protocol. Also extracts .render_view_sql(). Four test sites had hand-rolled the {url} substitution -- one commented as doing it 'exactly as .register_views() does' -- and all four broke on the second token. They now share the one function that knows the vocabulary, and a new test renders every SQL file to prove no token survives.	2026-08-08 17:11:44 -04:00