4 Commits

Include renames

Author	SHA1	Message	Date
jared	a9e80858d4	docs: correct coverage_window scope and the stale CLAUDE.md Current State block (#25) ... F-7: inst/schemas/provenance-v1.json described coverage_window as mapping each *observed* balance_subtype, but the query at R/balance_caveats.R has no predicate tied to the query's codes and always returns every subtype in the mounted corpus. Took option (b) of the two the review offered -- change the doc, not the code. Reporting all windows is the better product behaviour (it answers 'is there a family I missed?'), it is what cog-api#26 already forwards verbatim, and option (a) would make the block empty for a 0-row result. Reworded to say the windows are corpus-wide and that 'truncated' is the query-scoped field. Pinned by a new test either way. F-10: the 'Current State' block was self-contradictory after a partial update -- headed 2026-04-27, claiming branch main @ d65e9fe, with a 2026-08-03 test count measured on feat/cog-balances-25 underneath it, and listing README.md / _pkgdown.yml as outstanding when both exist and _pkgdown.yml was edited by this branch. All numbers below re-measured on the final tree after every other fix in this wave, not before: 788 tests (testthat::test_local()), 14 exports (NAMESPACE), 14 man/*.Rd, 2 vignettes, no docs/ (pkgdown::build_site() genuinely still outstanding, as is the .Rbuildignore fixture entry -- both kept in the list). The related deferred README.md item is closed with no change, per the review's ruling: README.md enumerates no verbs at all, so naming cog_balances would make it the only non-cog_spending verb mentioned.	2026-08-03 11:37:15 -04:00
jared	225cd60968	docs: fix stale test count and phantom notes column in cog_balances docs (#25) ... Re-measured CLAUDE.md's test count on the final tree (764, not 763 -- the earlier number predated the balance_caveats schema test). Removed notes from cog_balances()'s @return block: it was copied from cog_spending()'s @return style without checking cog_balances() never calls .verb_spendrev(), the only place that sets notes. Verified the remaining documented columns against colnames() observed across every argument combination (bare, per_capita, adjust_to_year, both, recipe, category filter).	2026-08-03 11:10:46 -04:00
jared	b03f095e49	docs: document cog_balances() and correct stale CLAUDE.md claims (#25) ... Adds the NEWS entry, a Financial data pkgdown reference section (none existed for cog_spending/cog_revenue), and corrects CLAUDE.md's SQL-layer claim, view count, test count and fixture-year description against measured values. Also documents balance_caveats in inst/schemas/provenance-v1.json (test-first: added a schema-documentation test to test-balances.R, confirmed it failed, then fixed the schema) and fleshes out cog_balances()'s @return roxygen to enumerate its conditional columns, regenerating man/cog_balances.Rd.	2026-08-03 11:02:16 -04:00
jared	b3e544ebd8	docs: add CLAUDE.md agent instructions with current state + v0.1 roadmap	2026-04-27 13:25:41 -04:00