2 Commits

Include renames

Author	SHA1	Message	Date
jared	93300ae0c1	feat: three-concept expenditure model classified by crosswalk membership (#11) ... Rewrites expenditure/revenue classification off item-code first-letter prefixes and onto summary_categories membership (F-018: prefix Y spans revenue, expenditure, and balance codes), and exposes expenditure_concept = c("primary", "direct", "total") with primary as the new default: primary = operations + capital + assistance direct = primary + interest + insurance_benefits (Census Direct) total = direct + intergovernmental (M/L/Q via ig views) - inst/sql: flow views (20-25) select by crosswalk membership; summary_categories moves to 11- so it registers before them (DuckDB binds view sources eagerly). The IG leg gains Q11/Q12/Q18 state school-system payments (F-017). - R: one subtype scope per verb call drives the verb SQL, the harmonization exclusion count, and the complete = TRUE grid; flow_prefixes survives only to scope recipe suggestions. cog_geographic_rollup/cog_peer_compare accept primary|direct, still refuse total, and now actually pass the concept through. - Balance codes can never reach a spending or revenue result (uscogdata#25), asserted at both view and verb level. - Deletes the #11 skip; per the 2026-07-30 owner ruling the F-018 Y01 proof is asserted against the crosswalk, not the default cog_revenue() call (which stays General Revenue pending #12). Suite: 696 pass / 0 fail / 1 skip (#12, expected). Closes #11	2026-07-30 16:56:50 -04:00
jared	9233c3d18e	test: add failing tests for Madison walkthrough findings ... Six skipped tests, one per issue opened from the Madison walkthrough audit (docs/walkthroughs/FINDINGS.md in cog_explorer). Each asserts the desired behaviour, so it fails today and goes green when the fix lands; each is guarded by a single skip() naming its issue and finding IDs, so the suite stays green and activating a test is a one-line deletion. test-expenditure-concepts.R #11 F-012, F-017, F-018 test-revenue-concept-insurance-trust.R #12 F-014 test-coverage-disclosure.R #13 F-020, F-023 test-peer-summary-scope.R #14 F-021 test-amount-units-documented.R #15 F-004 test-gov-search-literal-match.R #16 F-025 helper-walkthrough-raw.R reads the corpus's long parquet partitions directly, bypassing uscogdata's SQL views. Every expected amount comes from there rather than from the verb under test - verifying an absence through the filter that creates it proves nothing, which was the most common defect in the audit itself. Verified: with the skips removed all six fail (or error) against the bundled fixture; with them in place the full suite is 576 pass / 0 fail / 6 skip.	2026-07-29 00:14:11 -04:00