3 Commits

Include renames

Author	SHA1	Message	Date
jaredandClaude Opus 5	d258cef8c5	fix: gate direct-suppressed flag/note on an actually-covering recipe ... .detect_direct_suppressed() equated "no Direct sibling row" with "Direct was suppressed", but the dominant real cause is a government with genuinely no direct spending in that category (e.g. a state funding K-12 entirely through school districts) -- correct, ordinary data, not suppression. Measured: 32 of 50 states false-flagged on a clean FY2019 category = NULL total query, and all 141 flagged rows across 50 states x {2011, 2019} fell back to "no covering recipe found" instead of naming one -- including AL Corrections, which names corrections_combined correctly when category is supplied explicitly. Both the flag and its row note are now gated on a harmonization recipe actually covering that exact (year, canonical_govid, category) triple, via a new .covering_recipes() helper that runs the same generic recipe join per-row regardless of whether the caller supplied a category filter. .notes_column() takes the precomputed note vector directly instead of searching a category-gated suggestions list; .direct_suppressed_note() is removed (its "no recipe found" fallback no longer applies -- if no recipe covers a triple, it isn't suppression). Also recomputes two total-spending.Rmd figures the prior wave never actually reconciled with its own "measured against the fixture" caption: State IG/Direct (flat 17.2%, now 16.7%-48.4% varying by year) and City L/M (flat 188.3%, now 144%-189% varying by year). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-07-27 13:05:58 -04:00
jared	e7d3a7a310	docs: fix stale fixture description and Direct/Total vignette figures (M1, M2, M5) ... M5: README.md described the bundled fixture as a "3.6 MB two-year slice (2019 + 2020)"; it's now a 15 MB four-year slice (2011, 2012, 2019, 2020), matching the regenerated fixture and the vignette's own description. M2: total-spending.Rmd cited County 1.8% / City 0.8% intergovernmental- to-Direct and County 91.6% L/M, all roughly 2x off against the bundled fixture. Measured directly against the fixture (all 50 states, each of its four years): County IG/Direct 3.4%-5.1%, City IG/Direct 2.6%-3.1%, County L/M 43%-51% (all varying by year). State 17.2%, AL 7.6%, national 11.6%, and City L/M 188.3% were re-checked and left as-is. M1: the "Why Total = Direct + M + L" paragraph described money a local government *receives* and the state "redistributing as M" -- backwards. M and L are both the *queried* government's own payments *out*: M to other local governments, L up to its state. Rewrote the explanation; the conclusion and non-M2-flagged figures are unchanged.	2026-07-27 12:06:37 -04:00
jared	3bd9b1f011	docs: total-spending vignette + README section on Direct vs Total ... Task 7 (final) of the expenditure_concept plan. The vignette leads with the two archetype questions -- a single government's own trend (either concept works, held fixed across years) vs a cross-government rollup (direct only, with the refusal error from cog_geographic_rollup() shown and explained) -- walked through with code that runs against the bundled fixture corpus (years 2011/2012/2019/2020, substituting for "2017 vs today"). Explains the double-counting mechanism (a state's M44 payment to a county is the same dollar as the county's own E44/F44), why Total = Direct + M + L rather than Direct + M, and the composition rules (expenditure_concept is orthogonal to basis, mutually exclusive with recipe). README gets a short pointer section with the one-line rule.	2026-07-27 11:23:31 -04:00