The coarse and per-code signposting checks are partly DISJOINT, not nested:
coarse fires on queries per-code does not, so the coarse -> percode move
both adds and removes signposting. Every `*_delta_pp` the harness reports is
therefore a NET that can mask a coverage loss in either direction. The
staged-corpus headline (+1.875 pp, coarse 1/640 -> percode 13/640) sits on
top of Corrections losing coverage outright (0.05 -> 0.00, -5 pp).
The cause is structural, not sampling: coarse's coverage test is at recipe
grain and self-coverage-permissive, while per-code requires a DIFFERENT
component of the same recipe. When a whole category is empty in a year --
coarse's own trigger -- and the only covering evidence is the gapped
component's own wide-era aggregate row, per-code cannot fire by
construction. That case is already pinned as intended behaviour in
test-recipes.R; this change measures what it costs, it does not change it.
Measurement and disclosure only. R/suggestions.R is untouched -- which arm
ships is the human ruling at Checkpoint R3.
- header: replace the "noise trade" framing with an explicit statement that
the checks are partly disjoint and every delta is a net
- .measure_subset_relation(): split the disagreement into violations
(coarse fired, per-code silent -- coverage LOST) and additions, returning
the offending rows, not just counts. No assertion: the violation set is
genuinely non-empty and a stopifnot() would only break the harness that
is supposed to surface it
- .measure_format_subset_report(): prominent HOLDS / *** VIOLATED ***
section naming each offending (category, government, year)
- detail gains coarse_gap_years / coarse_recipes / percode_recipes;
by_category gains n_coarse_only / n_percode_only so the two netted flows
are visible per category
- new test-signposting-harness.R pins the reporting, including inversion
guards and an end-to-end case (Broward FY2011 Corrections) where coarse
fires and per-code does not
Tests: 518 PASS / 0 FAIL / 0 WARN / 0 SKIP (was 476). Mutation-checked:
inverting the violation direction fails 18 assertions, removing the
violation reporting fails 9.
jared
d238bc0a22