jared
9240a18ea3
Picks up pipeline PR #59: summary_categories now carries 66 M/L rows under spend_subtype = intergovernmental (194 -> 260 rows). cog_categories() (R/categories.R) has no item-code prefix filter, so the new IG rows surface immediately as a third spend subtype; this broke test-categories.R:18's closed enumeration. Adjudicated (2026-07-27): this is correct behavior, not a regression -- cog_categories() is a discovery verb documented to surface valid category values, and after Task 3 lands users will see spend_subtype = intergovernmental in cog_spending(expenditure_concept = total) results. Widened the subtype assertion and added positive coverage asserting the intergovernmental subtype and that it reuses existing functional categories (plus Other Education, pipeline #58). R/categories.R itself is unchanged -- its behavior was already right. Suite: PASS 469, FAIL 0 (baseline 467 + widened assertion + 2 new expectations).
74 lines
2.7 KiB
R
74 lines
2.7 KiB
R
test_that("cog_categories returns all categories grouped by subtype", {
|
|
skip_if_no_corpus()
|
|
r <- cog_categories()
|
|
expect_s3_class(r, "tbl_df")
|
|
expected <- c("category", "category_type", "subtype",
|
|
"n_codes", "item_codes")
|
|
expect_true(all(expected %in% names(r)))
|
|
expect_gt(nrow(r), 10L)
|
|
# corpus preserves Census-native "expenditure" vocabulary; the API takes
|
|
# "spending" as a friendlier alias.
|
|
expect_setequal(unique(r$category_type), c("expenditure", "revenue"))
|
|
})
|
|
|
|
test_that("cog_categories(type = 'spending') returns only expenditure rows", {
|
|
skip_if_no_corpus()
|
|
r <- cog_categories(type = "spending")
|
|
expect_true(all(r$category_type == "expenditure"))
|
|
expect_true(all(r$subtype %in% c("operations", "capital", "intergovernmental")))
|
|
})
|
|
|
|
test_that("cog_categories surfaces the intergovernmental spending subtype", {
|
|
skip_if_no_corpus()
|
|
r <- cog_categories(type = "spending")
|
|
expect_true("intergovernmental" %in% r$subtype)
|
|
# IG rows reuse the existing functional categories -- they add a subtype,
|
|
# not new category values.
|
|
ig_cats <- sort(unique(r$category[r$subtype == "intergovernmental"]))
|
|
direct_cats <- sort(unique(r$category[r$subtype != "intergovernmental"]))
|
|
expect_true(all(ig_cats %in% c(direct_cats, "Other Education")))
|
|
})
|
|
|
|
test_that("cog_categories(type = 'revenue') returns only revenue rows", {
|
|
skip_if_no_corpus()
|
|
r <- cog_categories(type = "revenue")
|
|
expect_true(all(r$category_type == "revenue"))
|
|
expect_true(all(r$subtype %in%
|
|
c("own_source", "federal", "state", "local_aid")))
|
|
})
|
|
|
|
test_that("cog_categories(pattern = ...) filters case-insensitively", {
|
|
skip_if_no_corpus()
|
|
r <- cog_categories(pattern = "police")
|
|
expect_gt(nrow(r), 0L)
|
|
expect_true(all(grepl("Police", r$category, ignore.case = TRUE)))
|
|
})
|
|
|
|
test_that("cog_categories has one row per (category, subtype)", {
|
|
skip_if_no_corpus()
|
|
r <- cog_categories()
|
|
key <- paste(r$category, r$subtype, sep = "|")
|
|
expect_equal(length(key), length(unique(key)))
|
|
})
|
|
|
|
test_that("cog_categories item_codes is non-empty comma-separated string", {
|
|
skip_if_no_corpus()
|
|
r <- cog_categories()
|
|
expect_true(all(nzchar(r$item_codes)))
|
|
expect_true(all(r$n_codes >= 1L))
|
|
# n_codes should equal count of commas + 1
|
|
expect_equal(r$n_codes,
|
|
vapply(strsplit(r$item_codes, ","), length, integer(1)))
|
|
})
|
|
|
|
test_that("cog_categories sorted by category_type, category, subtype", {
|
|
skip_if_no_corpus()
|
|
r <- cog_categories()
|
|
sorted <- r[order(r$category_type, r$category, r$subtype), ]
|
|
expect_identical(r, sorted)
|
|
})
|
|
|
|
test_that("cog_categories rejects invalid type", {
|
|
expect_error(cog_categories(type = "both"), "type")
|
|
})
|